cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7045) improve plugman install (+spec)
Date Wed, 02 Jul 2014 19:38:25 GMT

    [ https://issues.apache.org/jira/browse/CB-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050606#comment-14050606
] 

ASF subversion and git services commented on CB-7045:
-----------------------------------------------------

Commit fb3c8d63ff3714723c5525e9b3c6de1157bcb14f in cordova-lib's branch refs/heads/master
from [~jsoref]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=fb3c8d6 ]

CB-7045 (fix up quotes to make jshint happy)


> improve plugman install (+spec)
> -------------------------------
>
>                 Key: CB-7045
>                 URL: https://issues.apache.org/jira/browse/CB-7045
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugman
>    Affects Versions: 3.5.0
>            Reporter: Josh Soref
>            Assignee: Josh Soref
>             Fix For: 3.6.0
>
>
> Currently install.spec skips some of its tests, i'd like more of them to work.
> {quote}
> function checkEngines(engines) {
> ...
>         if ( semver.satisfies(engine.currentVersion, engine.minVersion) || engine.currentVersion
=== null ) {
> {quote}
> this expects currentVersion to be a *number* or {{null}}, but currently it's possible
for it to be {{""}}
> {{cleanVersionOutput}} will take {{""}} and return {{""}} which isn't helpful...
> {{callEngineScripts}} calls {{child_process.exec(scriptPath...}} and handles error, but
not no output.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message