cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7037) platform check doesn't warn when it can't install a platform
Date Wed, 02 Jul 2014 17:03:27 GMT

    [ https://issues.apache.org/jira/browse/CB-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050333#comment-14050333
] 

ASF GitHub Bot commented on CB-7037:
------------------------------------

Github user jsoref closed the pull request at:

    https://github.com/apache/cordova-lib/pull/42


> platform check doesn't warn when it can't install a platform
> ------------------------------------------------------------
>
>                 Key: CB-7037
>                 URL: https://issues.apache.org/jira/browse/CB-7037
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI, CordovaLib
>    Affects Versions: 3.5.0
>            Reporter: Josh Soref
>
> `cordova platform check` basically tries to create a new project with the same platforms
as in your current project. It doesn't complain about projects for which it can't get a version
- the original thinking was:
> {quote}
>                 /* If a platform doesn't install, then we can't realistically suggest
updating */
> {quote}
> https://github.com/apache/cordova-lib/blob/0abfcded491fc4e15e24992ba101a5863513a1a7/cordova-lib/src/cordova/platform.js#L250-L251
> The problem is that if you try to add android, it will often fail because one or both
of "android" or "ant" will be missing from your path. Since check can't install android, it
can't get its version and thus can't determine it isn't current. 
> We should add some logic so that it can report that it can't determine instead of making
the admittedly stronger claim of "up-to-date". 
> {quote}
> https://github.com/apache/cordova-lib/blob/0abfcded491fc4e15e24992ba101a5863513a1a7/cordova-lib/src/cordova/platform.js#L262
> {quote}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message