cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Javier Puerto (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-6928) Wrong behaviour transferring cacheable content
Date Mon, 14 Jul 2014 11:00:07 GMT

    [ https://issues.apache.org/jira/browse/CB-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060535#comment-14060535
] 

Javier Puerto commented on CB-6928:
-----------------------------------

Thanks [~iclelland] for handling the PR . Still missing the PR to cordova-mobile-spec with
the test case and the change to documentation to add the new error status code. I'm not sure
about the test as following the dev mailing list I've seen that there's a plan to change the
tests soon. Shall I close this PR? on the other hand, I think that the changes to the documentation
to explain the new status code it's necessary.

> Wrong behaviour transferring cacheable content
> ----------------------------------------------
>
>                 Key: CB-6928
>                 URL: https://issues.apache.org/jira/browse/CB-6928
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File Transfer
>    Affects Versions: 3.5.0
>            Reporter: Javier Puerto
>            Priority: Minor
>         Attachments: CB-6928.diff
>
>
> Use case:
> Transfer resources from server to the device. To avoid unnecessary use of the device
bandwidth, the resources that exists already are checked with the "If-Modified-Since" header
so server can return 304 status code and update just in case that is needed.
> Result for Android test:
> The plugin doesn't care about the status code, if the request is success, open the InputStream
and copy the content to the file. The problem is that a HTTP status of 304 has no response
and that leads to a corrupted file transfer.
> Fix:
> If status code is 304, doesn't makes sense to process the InputStream. Read the status
code after connection and if it's 304, skip the copy process and return the file entity like
a success transfer.
> I've tested for Android only.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message