cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-6776) Make project/.cordova/config.json integrate with platforms.js
Date Wed, 02 Jul 2014 16:23:24 GMT

    [ https://issues.apache.org/jira/browse/CB-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050266#comment-14050266
] 

ASF GitHub Bot commented on CB-6776:
------------------------------------

Github user kamrik commented on the pull request:

    https://github.com/apache/cordova-lib/pull/9#issuecomment-47798569
  
    This seems to deal quite a lot with check_requirements(). Considering the discussion last
Thursday, should we first stop using check_requirements() and then add the remaining changes
from this PR?
    
    A nit:
    The lazy_load.mixin() func seems to be the same as underscore.extend() http://underscorejs.org/#extend
 
    
    Other than that looks good.


> Make project/.cordova/config.json integrate with platforms.js
> -------------------------------------------------------------
>
>                 Key: CB-6776
>                 URL: https://issues.apache.org/jira/browse/CB-6776
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 3.5.0
>            Reporter: Josh Soref
>            Assignee: Josh Soref
>
> Handling of .cordova/config.json , platforms and lazy_load is currently fairly messy.
> This removes hardcoded platforms.js handling from lazy_load (especially for wp7/wp8 and
blackberry10).
> It also allows other future platforms to have whatever odd behavior they like (similar
to wp7/wp8/blackberry10) if they so choose.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message