cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-3562) Wrong splash screen ratio for landscape-only applications
Date Wed, 02 Jul 2014 20:22:25 GMT

    [ https://issues.apache.org/jira/browse/CB-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050662#comment-14050662
] 

ASF GitHub Bot commented on CB-3562:
------------------------------------

Github user agrieve commented on the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-47830696
  
    Ah, I gotcha, It's because the shouldAutorotate selector has no setter in CDVViewController.
    
    @shazron - any opinion on this? with swizzling it will work with existing cordova-ios,
but it would be easy to make a setter for shouldAutorotate settable, or alternatively make
supportedOrientations public. I'm leaning towards accepting this as-is since it works and
only swizzles a UIViewController selector.


> Wrong splash screen ratio for landscape-only applications
> ---------------------------------------------------------
>
>                 Key: CB-3562
>                 URL: https://issues.apache.org/jira/browse/CB-3562
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS, Plugin SplashScreen
>    Affects Versions: 2.6.0, 2.7.0, 2.9.0
>            Reporter: Michael Hanselmann
>            Assignee: Shazron Abdullah
>             Fix For: 3.4.0
>
>
> CDVSplashScreen.m shows the splash image with a wrong ratio for landscape-only applications
on iPhone/iPod touch devices. I fixed it locally by applying a 90° transformation (“CGAffineTransformMakeRotation(M_PI
/ 2)”) to the image view.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message