Return-Path: 
 <issues-return-27116-apmail-cordova-issues-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org
Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id BF13B11391
	for <apmail-cordova-issues-archive@minotaur.apache.org>;
 Thu, 12 Jun 2014 18:37:05 +0000 (UTC)
Received: (qmail 28837 invoked by uid 500); 12 Jun 2014 18:37:05 -0000
Delivered-To: apmail-cordova-issues-archive@cordova.apache.org
Received: (qmail 28765 invoked by uid 500); 12 Jun 2014 18:37:05 -0000
Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cordova.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cordova.apache.org>
List-Post: <mailto:issues@cordova.apache.org>
List-Id: <issues.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list issues@cordova.apache.org
Received: (qmail 28670 invoked by uid 99); 12 Jun 2014 18:37:05 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Jun 2014 18:37:05 +0000
Date: Thu, 12 Jun 2014 18:37:05 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12718974.1402098024498.120050.1402598225054@arcas>
In-Reply-To: <JIRA.12718974.1402098024498@arcas>
References: <JIRA.12718974.1402098024498@arcas>
Subject: [jira] [Commented] (CB-6895) Generated manifest skips some
 properties
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CB-6895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029570#comment-14029570 ] 

ASF GitHub Bot commented on CB-6895:
------------------------------------

Github user rodms10 commented on the pull request:

    https://github.com/apache/cordova-lib/pull/26#issuecomment-45930663
  
    Yeah, the priorities are pretty messy right now. Currently content in `config.xml` takes precedence on all manifest properties, except two: `permissions` and `icons`. 
    
    For icons we added config to `default.xml` which end up in your platform's `config.xml`. For permissions we update `plugin.xml` to add a `permission` element to the same platform's `config.xml`. The problem is that this file is recreated from scratch on every prepare. Which means you can't edit it.
    
    Because those 2 properties do not take precedence, you can overwrite them on the manifest. But for that to work you need to create a manifest file in your root `www` folder or in `merges`.
    
    You can edit your root `config.xml` to alter these properties too, like so:
    ``` xml
    <platform name="firefoxos">
      <permission description="Will be required for accessing user location." name="geolocation" />
      <icon height="128" src="nonwicon/icon-128.png" width="128" />
      <icon height="60" src="noneicon/icon-60.png" width="60" />
    </platform>
    ```
    
    This will create duplicates on the platform `config.xml`, that will come after whatever is defined in `defaults.xml` or `plugins.xml`. It will be ignored by current code since what comes first takes precedence.
    
    That said, I think that editing the root `config.xml` should be the "official" way of changing those properties in the manifest and I made the changes to make it possible. The down side is that you can't overwrite them with a manifest anymore, but that is better aligned with cordova and removes the exceptions to precedence rules.
    
    Note that I amended the commit to the last one.


> Generated manifest skips some properties
> ----------------------------------------
>
>                 Key: CB-6895
>                 URL: https://issues.apache.org/jira/browse/CB-6895
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: FirefoxOS
>    Affects Versions: 3.5.0
>            Reporter: Rodrigo Silveira
>            Assignee: Rodrigo Silveira
>
> The properties *launch_path* and *installs_allowed_from* are hard coded and should instead come from *content* and *access* elements in *config.xml*.
> Manifest doesn't support fullscreen and portrait.
> See [config.xml docs|http://cordova.apache.org/docs/en/3.5.0/config_ref_index.md.html#The%20config.xml%20File] for cordova props we can use and [app manifest doc|https://developer.mozilla.org/en-US/Apps/Build/Manifest] for what firefoxos supports.



--
This message was sent by Atlassian JIRA
(v6.2#6252)