Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Date: Wed, 4 Jun 2014 17:45:03 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12706408.1396528615719.71516.1401903903512@arcas>
In-Reply-To: <JIRA.12706408.1396528615719@arcas>
References: <JIRA.12706408.1396528615719@arcas>
Subject: [jira] [Commented] (CB-6396) inappbrowser
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/CB-6396?page=3Dcom.atlassian.ji=
ra.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1401791=
9#comment-14017919 ]=20

ASF GitHub Bot commented on CB-6396:
------------------------------------

Github user rodms10 commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/47#discussio=
n_r13399892
 =20
    --- Diff: doc/index.md ---
    @@ -99,6 +100,39 @@ instance, or the system browser.
         var ref =3D window.open('http://apache.org', '_blank', 'location=
=3Dyes');
         var ref2 =3D window.open(encodeURI('http://ja.m.wikipedia.org/wiki=
/=E3=83=8F=E3=83=B3=E3=82=B0=E3=83=AB'), '_blank', 'location=3Dyes');
    =20
    +### Firefox OS Quirks
    +
    +As plugin doesn't enforce any design there is a need to add some CSS r=
ules if=20
    +opened with `target` `'_blank'`. The rules might look like these
    --- End diff --
   =20
    nit: `target` and `_blank` could be in a single block like: `target=3D'=
_blank' `


> inappbrowser
> ------------
>
>                 Key: CB-6396
>                 URL: https://issues.apache.org/jira/browse/CB-6396
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Plugin InAppBrowser
>    Affects Versions: 3.6.0
>            Reporter: Piotr Zalewa
>            Assignee: Piotr Zalewa
>
> Add InAppBrowser for firefoxos


--
This message was sent by Atlassian JIRA
(v6.2#6252)