cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-6954) Share events.js between cordova and plugman
Date Tue, 17 Jun 2014 16:49:07 GMT

    [ https://issues.apache.org/jira/browse/CB-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034023#comment-14034023
] 

ASF GitHub Bot commented on CB-6954:
------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-lib/pull/31


> Share events.js between cordova and plugman
> -------------------------------------------
>
>                 Key: CB-6954
>                 URL: https://issues.apache.org/jira/browse/CB-6954
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Sergey Grebnov
>            Assignee: Sergey Grebnov
>              Labels: cordova, cordova-lib, plugman, refactoring
>
> Currently there are two instances of events.js under cordova and plugman folders which
provide exactly the same functionality.
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/events.js
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/events.js
> This is common functionality which must be shared among cordova and plugman so must be
moved to some common folder (src/events.js???).  Similar to CordovaError and xml-helpers.js
> It is also required to be able to reference to 'events' from shared code - as an example,
common Hooks code which emits messages via 'events'.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message