cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-6889) "Edit json" step in master.cfg fails on Windows
Date Thu, 19 Jun 2014 11:08:24 GMT

    [ https://issues.apache.org/jira/browse/CB-6889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037232#comment-14037232
] 

ASF GitHub Bot commented on CB-6889:
------------------------------------

GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-medic/pull/12

    CB-6889, CB-6899, CB-6909 Multiple fixes in master.cfg to ensure proper work on windows
slaves

    This includes #9, #10 and #11 with conflicts resolved.
    Issues: [CB-6899](https://issues.apache.org/jira/browse/CB-6899), [CB-6889](https://issues.apache.org/jira/browse/CB-6889),
[CB-6909](https://issues.apache.org/jira/browse/CB-6909)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-medic #493

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-medic/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12
    
----
commit 69a6ae92ced92c51cf12ec83b180a24308881bd0
Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
Date:   2014-06-09T11:51:50Z

    Change "-i" sed's argument behaviour, which now works on both mac and windows.

commit 8e843e92fee168986859cc34c3adc2302b62e72e
Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
Date:   2014-06-09T13:35:12Z

    Removes platform-dependent shellCmd and shellRunParam from master.cfg

commit 71267310940275eb83c8d1b2af1f7c491844fdaf
Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
Date:   2014-06-09T08:57:42Z

    Replaces "ln -s" command, which is not working on windows slaves, with inline node script.

commit 4ce33403396ee4edd078bc8bf40a65ca94e79311
Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
Date:   2014-06-19T10:54:37Z

    Merge branch 'CB-6889' into #493

commit 75f735a58255c1a75d4fd938273a897df017b32e
Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
Date:   2014-06-19T10:55:05Z

    Merge branch 'CB-6909' into #493

commit 628926883ba59fc941c696628276b55b9e590385
Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
Date:   2014-06-19T10:58:18Z

    Merge branch 'CB-6899' into #493
    
    Conflicts:
    	master.cfg

----


> "Edit json" step in master.cfg fails on Windows
> -----------------------------------------------
>
>                 Key: CB-6889
>                 URL: https://issues.apache.org/jira/browse/CB-6889
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Medic, Windows 8, WP8
>            Reporter: Vladimir Kotikov
>            Assignee: Jesse MacFadyen
>
> When running medic on windows (either the client and server or just a client), the Edit
json step specified in master.cfg fails.
> Reason: Windows medic install uses the unix utilities from git\bin, the version of sed
installed requires specification of backup suffix for {{-i}} option without space.
> {noformat}
>   -i[SUFFIX], --in-place[=SUFFIX]
>                  edit files in place (makes backup if extension supplied)
> {noformat}
> from sed help.
> {{sed -e 's/cordova-lib": "0./cordova-lib": ">=0./' -ibak package.json}} instead of
{{sed -e 's/cordova-lib": "0./cordova-lib": ">=0./' -i bak package.json}} works fine on
both windows and mac.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message