cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-6711) Adding multiple plugins for iOS is broken
Date Wed, 28 May 2014 14:56:01 GMT

    [ https://issues.apache.org/jira/browse/CB-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011158#comment-14011158
] 

ASF GitHub Bot commented on CB-6711:
------------------------------------

Github user mbektchiev commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/15#discussion_r13135048
  
    --- Diff: cordova-lib/src/plugman/util/config-changes.js ---
    @@ -510,8 +509,7 @@ function ConfigFile_load() {
             self.data = xml_helpers.parseElementtreeSync(filepath);
         } else if (ext == '.pbxproj') {
             self.type = 'pbxproj';
    -        self.data = xcode.project(filepath);
    -        self.data.parseSync();
    +        self.data = platforms.ios.parseProjectFile(self.project_dir).xcode;
    --- End diff --
    
    `parseProjectFile` is  called when processing the action-stack, so even if we skip the
call here, it will eventually happen. What was the purpose of this optimization? I think that
it may only have effect on the unit tests execution time.


> Adding multiple plugins for iOS is broken
> -----------------------------------------
>
>                 Key: CB-6711
>                 URL: https://issues.apache.org/jira/browse/CB-6711
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugman
>            Reporter: Martin Bektchiev
>            Assignee: Martin Bektchiev
>
> When adding multiple plugins for iOS projects framework config changes get overwritten.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message