Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Date: Thu, 24 Apr 2014 14:58:16 +0000 (UTC)
From: "Michal Mocny (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12710325.1398350691189.172784.1398351496143@arcas>
In-Reply-To: <JIRA.12710325.1398350691189@arcas>
References: <JIRA.12710325.1398350691189@arcas>
Subject: [jira] [Commented] (CB-6508) Should run pre-prepare hooks even when
 no platforms installed
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979806#comment-13979806 ] 

Michal Mocny commented on CB-6508:
----------------------------------

A few thoughts about prepare hooks.  Which of the following are we doing?:
- for_each pre-prepare hook, run it once with no inputs
- for_each pre-prepare hook, run it once with the list of target platforms as input
- for_each pre-prepare hook, run it many times, once for each platform target

For option 1, installing platforms during pre-prepare is fine.
For option 2, the hook has to be able to append that new platform to the list of targets, so we need ways to resolve paths etc.
For option 3, it gets confusing.  Installing platforms is kinda pre-pre-prepare init type action in this case.  Do we need a new hook category?

> Should run pre-prepare hooks even when no platforms installed
> -------------------------------------------------------------
>
>                 Key: CB-6508
>                 URL: https://issues.apache.org/jira/browse/CB-6508
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>            Reporter: Michal Mocny
>            Assignee: Mark Koudritsky
>            Priority: Minor
>
> My app has a before_prepare hook that installs necessary platforms, but it currently won't run since we early exit if there are no platforms installed.  We assume there is no work to be done during prepare, but in this case that isn't true.


--
This message was sent by Atlassian JIRA
(v6.2#6252)