Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 075DB11DBF for ; Fri, 11 Apr 2014 14:58:29 +0000 (UTC) Received: (qmail 46720 invoked by uid 500); 11 Apr 2014 14:58:23 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 45492 invoked by uid 500); 11 Apr 2014 14:58:18 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 45453 invoked by uid 99); 11 Apr 2014 14:58:15 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Apr 2014 14:58:15 +0000 Date: Fri, 11 Apr 2014 14:58:15 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-6405) [WP8] Make InAppBrowser work with embedded files, using system behavior MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-6405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966604#comment-13966604 ] ASF GitHub Bot commented on CB-6405: ------------------------------------ GitHub user nadyaA opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/38 Make InAppBrowser work with embedded files, using system behavior http://teampulse.telerik.com/view#item/257913 The plugin is changed to work with embedded files, using the system behavior. If one needs the system behavior, they need to pass "_system" as target when using the plugin. As the InAppBrowser for WP8 does not handle by itself the embedded pdf files, system behavior is called. The plugin also is tested and working for wp7 https://issues.apache.org/jira/browse/CB-6405 Also this PR solves null reference exception, if no "options" are provided: WP8: InAppBrowser NullReferenceException when the "options" param not passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-plugin-inappbrowser wp8-work-with-embedded-files Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/38.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #38 ---- commit fb414268b298d2a7950bcfe19d96d28bc171e406 Author: Nadya Atanasova Date: 2014-04-11T14:34:33Z Make InAppBrowser work with embedded files, using system behavior http://teampulse.telerik.com/view#item/257913 The plugin is changed to work with embedded files, using the system behavior. If one needs the system behavior, they need to pass "_system" as target when using the plugin. As the InAppBrowser for WP8 does not handle by itself the embedded pdf files, system behavior is called. The plugin also is tested and working for wp7 ---- > [WP8] Make InAppBrowser work with embedded files, using system behavior > ----------------------------------------------------------------------- > > Key: CB-6405 > URL: https://issues.apache.org/jira/browse/CB-6405 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin InAppBrowser > Affects Versions: 3.2.0 > Reporter: Nadya Atanasova > Priority: Trivial > > When trying to open embedded file, the browser is not working. -- This message was sent by Atlassian JIRA (v6.2#6252)