cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-6377) CLI is unable to create a project when there are spaces in the path
Date Mon, 14 Apr 2014 11:17:18 GMT

    [ https://issues.apache.org/jira/browse/CB-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968250#comment-13968250
] 

ASF GitHub Bot commented on CB-6377:
------------------------------------

Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-cli/pull/161#issuecomment-40355369
  
    LGTM + Tested.
    
    I think we should accept the changes and then look on the following improvements:
    
    1. The line below is very complex to read/understand. Move to separate fn + simplify +
comments?
    
          [['/s', '/c', '"'+[cmd].concat(args).map(function(a){if (/^[^"].* .*[^"]/.test(a))
return '"'+a+'"'; return a;}).join(" ")+'"'].join(" ")];
    
    2. Not sure we should use two different cases - if there is white space and not. Single
case is preferred since we don't need to test both cases.


> CLI is unable to create a project when there are spaces in the path
> -------------------------------------------------------------------
>
>                 Key: CB-6377
>                 URL: https://issues.apache.org/jira/browse/CB-6377
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 3.4.0
>            Reporter: JennyGee
>            Assignee: Josh Soref
>            Priority: Critical
>
> Unable to create a project where there are spaces in the path.
> C:\Program Files\BlackBerry\BB10 WebWorks SDK 2.1.0.3\webworks-cli\node_modules\
> wrench\lib\wrench.js:249
>         if (e.code !== 'EEXIST') throw e;
>                                        ^
> Error: ENOENT, no such file or directory 'C:\Documents and Settings\IEUser\.cord
> ova\lib\blackberry10\cordova\v2.1.0.3'
>     at Object.fs.mkdirSync (fs.js:642:18)
>     at Object.exports.copyDirSyncRecursive (C:\Program Files\BlackBerry\BB10 Web
> Works SDK 2.1.0.3\webworks-cli\node_modules\wrench\lib\wrench.js:246:12)
>     at Object._self.fetchBlackBerry (C:\Program Files\BlackBerry\BB10 WebWorks S
> DK 2.1.0.3\webworks-cli\lib\utils\utils.js:59:20)
>     at new CLI (C:\Program Files\BlackBerry\BB10 WebWorks SDK 2.1.0.3\webworks-c
> li\lib\cli.js:48:19)
>     at Object.<anonymous> (C:\Program Files\BlackBerry\BB10 WebWorks SDK 2.1.0.3
> \webworks-cli\bin\webworks:4:16)
>     at Module._compile (module.js:456:26)
>     at Object.Module._extensions..js (module.js:474:10)
>     at Module.load (module.js:356:32)
>     at Function.Module._load (module.js:312:12)
>     at Function.Module.runMain (module.js:497:10)
> Looking at the source code, it appears that https://issues.apache.org/jira/browse/CB-6323
broke https://issues.apache.org/jira/browse/CB-6306



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message