cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-6344) Specify after which sibling to add config-changes in plugin.xml
Date Tue, 01 Apr 2014 14:46:16 GMT

    [ https://issues.apache.org/jira/browse/CB-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956575#comment-13956575
] 

ASF GitHub Bot commented on CB-6344:
------------------------------------

GitHub user mbektchiev opened a pull request:

    https://github.com/apache/cordova-plugman/pull/69

    CB-6344: Specify after which sibling to add config-changes in plugin.xml

    * refactor munges - now they are in a more extensible form (munge.files[file].parents[parent][index]
{ xml, count, after })
    * add an after parameter to graftXML which contains a list of possible predecessor elements
separated by semicolon
    * fix unit tests and add new ones
    
    
    https://github.com/apache/cordova-cli/pull/157 fixes the tests which failed the previous
time these changes got merged.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Icenium/cordova-plugman config-file-after-option

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugman/pull/69.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #69
    
----
commit 6b7a9e0438888d2091436aafce84d60ea753486d
Author: Martin Bektchiev <martin.bektchiev@telerik.com>
Date:   2014-03-26T08:15:39Z

    CB-6344: Specify after which sibling to add config-changes in plugin.xml
    
    * refactor munges - now they are in a more extensible form (munge.files[file].parents[parent][index]
{ xml, count, after })
    * add an after parameter to graftXML which contains a list of possible predecessor elements
separated by semicolon
    * fix unit tests and add new ones
    
    github: close #68

----


> Specify after which sibling to add config-changes in plugin.xml
> ---------------------------------------------------------------
>
>                 Key: CB-6344
>                 URL: https://issues.apache.org/jira/browse/CB-6344
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugman
>            Reporter: Martin Bektchiev
>            Assignee: Martin Bektchiev
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> The order of XML elements is important In the Windows Phone manifest file.  (e.g. see
http://msdn.microsoft.com/en-us/library/windowsphone/develop/ff769509%28v=vs.105%29.aspx#BKMK_EXTENSIONSelement).
That's why we need to provide a way to specify where a specific element has to be added.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message