cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-6344) Specify after which sibling to add config-changes in plugin.xml
Date Tue, 01 Apr 2014 14:44:23 GMT

    [ https://issues.apache.org/jira/browse/CB-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956574#comment-13956574
] 

ASF GitHub Bot commented on CB-6344:
------------------------------------

GitHub user mbektchiev opened a pull request:

    https://github.com/apache/cordova-cli/pull/157

    Fix spy to return a default platform JSON instead of an empty object

    Fixes broken tests because of the refactoring in plugman regarding CB-6344

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Icenium/cordova-cli fix-unit-tests-for-CB-6344

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-cli/pull/157.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #157
    
----
commit 766357377ba6b7c4c316a539365c0baffc3a3993
Author: Martin Bektchiev <martin.bektchiev@telerik.com>
Date:   2014-04-01T14:23:11Z

    Fix spy to return a default platform JSON instead of an empty object
    
    Fixes broken tests because of the refactoring in plugman regarding CB-6344

----


> Specify after which sibling to add config-changes in plugin.xml
> ---------------------------------------------------------------
>
>                 Key: CB-6344
>                 URL: https://issues.apache.org/jira/browse/CB-6344
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugman
>            Reporter: Martin Bektchiev
>            Assignee: Martin Bektchiev
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> The order of XML elements is important In the Windows Phone manifest file.  (e.g. see
http://msdn.microsoft.com/en-us/library/windowsphone/develop/ff769509%28v=vs.105%29.aspx#BKMK_EXTENSIONSelement).
That's why we need to provide a way to specify where a specific element has to be added.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message