cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-6329) [cordova-cli] improve 'cordova info' command to work asynchronous
Date Fri, 04 Apr 2014 16:39:14 GMT

    [ https://issues.apache.org/jira/browse/CB-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960113#comment-13960113
] 

ASF GitHub Bot commented on CB-6329:
------------------------------------

Github user martincgg commented on the pull request:

    https://github.com/apache/cordova-cli/pull/151#issuecomment-39585091
  
    Last commit.
    -Removed functions: appendLog, writeLog, delLog.
    -No indent on top-level functions
    -Changed for loop from for(var t in promises) to
    promises.forEach(function(p))
    -Other minor changes
    
    Well @agrieve , this is what I got, I have a combination of callbacks and promises, trying
to take good advantages of both of them, you have more experience and expertise than me in
this subject, if you want me to change the whole thing to promises, just let me know, but
I rather focus efforts on in adding support to other platforms and make more improvements,
but like I said, if you consider that the best action to take is change the whole thing to
promises and not a combination of callbacks and promises, it's Ok, I'll do it.
    Thanks a lot again for your feedback.


> [cordova-cli] improve 'cordova info' command to work asynchronous
> -----------------------------------------------------------------
>
>                 Key: CB-6329
>                 URL: https://issues.apache.org/jira/browse/CB-6329
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CLI
>    Affects Versions: 3.4.0
>            Reporter: Martin Gonzalez
>            Assignee: Martin Gonzalez
>              Labels: blackberry, cordova-cli, environment, info, wp8
>             Fix For: 3.5.0
>
>
> The 'cordova info' command it works in total sync, it takes some time to pull and push
all data from the environment, so in order to use callbacks more friendly, I'd like to modify
the flow structure of the file and improve it to use get callback outputs, write summary or
log file without templates.
> I also, I'd like to add a secondary file that holds all specific functions related with
'get information about the dev environment'.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message