cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-6329) [cordova-cli] improve 'cordova info' command to work asynchronous
Date Wed, 23 Apr 2014 09:26:15 GMT


ASF GitHub Bot commented on CB-6329:

Github user martincgg commented on the pull request:
    I've been working on some other stuff with cordova-mobile-spec, but I came back to this
topic to deliver the pending changes removing callback functions, and use only promises and
superspawn following the recommendations and feedback provided.
    -Removed: All callbacks functions.
    -Every function returns a promise.
    -Use of superspawn instead of shelljs.
    -Use of Q.defer(), to resolve or reject promises.
    -Removed mostly all anonymous functions.
    It's cleaner and complexity has been reduced without promises-callbacks
    statements combination.
    Q.allSettled it will wait until all promises are resolved, and then write the log file,
collecting all data.
    @agrieve , thanks for the feedback and all the suggestions that you provided me. If this
is last commit is well accomplished, let me know to start to work on add support for blackberry,
wp8 and windows 8, using the same pattern.

> [cordova-cli] improve 'cordova info' command to work asynchronous
> -----------------------------------------------------------------
>                 Key: CB-6329
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CLI
>    Affects Versions: 3.4.0
>            Reporter: Martin Gonzalez
>            Assignee: Martin Gonzalez
>              Labels: blackberry, cordova-cli, environment, info, wp8
>             Fix For: 3.5.0
> The 'cordova info' command it works in total sync, it takes some time to pull and push
all data from the environment, so in order to use callbacks more friendly, I'd like to modify
the flow structure of the file and improve it to use get callback outputs, write summary or
log file without templates.
> I also, I'd like to add a secondary file that holds all specific functions related with
'get information about the dev environment'.

This message was sent by Atlassian JIRA

View raw message