cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-5816) FirefoxOS - add build script
Date Fri, 25 Apr 2014 15:28:20 GMT

    [ https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981142#comment-13981142
] 

ASF GitHub Bot commented on CB-5816:
------------------------------------

Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001480
  
    --- Diff: bin/templates/project/cordova/lib/build.js ---
    @@ -0,0 +1,167 @@
    +#!/usr/bin/env node
    +
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    + 
    +var path = require('path'),
    +    fs = require('fs'),
    +    clean = require('./clean'),
    +    shjs = require('shelljs'),
    +    zip = require('adm-zip'),
    +    check_reqs = require('./check_reqs'),
    +    buildDirInMerge ='build--release';
    +
    +function hasMergesCustomReleaseArtifactsDir() {
    +    return fs.existsSync('merges/firefoxos/'+buildDirInMerge);
    --- End diff --
    
    this should normally be done using path.join() i think


> FirefoxOS - add build script
> ----------------------------
>
>                 Key: CB-5816
>                 URL: https://issues.apache.org/jira/browse/CB-5816
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: FirefoxOS
>            Reporter: Axel Nennker
>
> run:  cordova build firefoxos
> output:
> Generating config.xml from defaults for platform "firefoxos"
> Preparing firefoxos project
> Compiling app on platform "firefoxos" via command "/project/platforms/firefoxos/cordova/build"

> events.js:72
>         throw er; // Unhandled 'error' event
>               ^
> Error: spawn ENOENT
>     at errnoException (child_process.js:980:11)
>     at Process.ChildProcess._handle.onexit (child_process.js:771:34)
> project$ 
> expected output: 
> nothing
> ---------
> platforms/firefoxos/cordova/build does not exist so the "cordova build firefoxos" command
fails.
> Please add a "build" script (although it does nothing)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message