cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Soref (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-6323) platform superspawn exists version check is unfortunate
Date Sun, 23 Mar 2014 18:50:43 GMT

    [ https://issues.apache.org/jira/browse/CB-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944529#comment-13944529
] 

Josh Soref commented on CB-6323:
--------------------------------

+    var winExtensions = ['.exe', '.cmd', '.bat', '.js', '.vbs'];
+    function isValidExe(c) {
+        return winExtensions.indexOf(path.extname(cmd)) !== -1 && fs.existsSync(cmd);
+    }

This doesn't look right, where's "c" used?

> platform superspawn exists version check is unfortunate
> -------------------------------------------------------
>
>                 Key: CB-6323
>                 URL: https://issues.apache.org/jira/browse/CB-6323
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI, Windows 8
>    Affects Versions: 3.4.0
>            Reporter: Josh Soref
>            Assignee: Andrew Grieve
>
> The code before CB-5181 / {{b675ee35d5b92f5b997a834d4e6575e1edc14ef3}} didn't really
look before it leapt, which meant that a platform with only a {{cordova/version.bat}} and
no {{cordova/version}} would magically work.
> While I'm not sure of any Windows only platforms, it doesn't seem unreasonable.
> A quick check confirms that in fact *windows8* doesn't have this file.
> {{https://git-wip-us.apache.org/repos/asf/cordova-windows.git}} @ {{ca106cfd91efa74b3556d70b6a936e77d85ec169}}
> {quote}
> cordova-windows $ find windows8 -name 'versi*'
> windows8/template/cordova/version.bat
> {quote}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message