cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-6322) Simplify platforms/platform code for platform specifics
Date Mon, 31 Mar 2014 18:13:16 GMT

    [ https://issues.apache.org/jira/browse/CB-6322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955465#comment-13955465
] 

ASF GitHub Bot commented on CB-6322:
------------------------------------

Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/146#discussion_r11128647
  
    --- Diff: platforms.js ---
    @@ -39,12 +41,14 @@ module.exports = {
             version: '3.4.0'
         },
         'wp7' : {
    +        hostos : ['win32'],
    --- End diff --
    
    Thanks for finding that. We'll have to get rid of this anti-pattern in the code (my bad).


> Simplify platforms/platform code for platform specifics
> -------------------------------------------------------
>
>                 Key: CB-6322
>                 URL: https://issues.apache.org/jira/browse/CB-6322
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 3.4.0
>            Reporter: Josh Soref
>            Assignee: Josh Soref
>
> Currently people who want to add a platform have to hack both platforms.js and platform.js
> Ideally they shouldn't have to hack platform.js at all.
> Before this change:
> {quote}
> $ cordova platform
> Installed platforms: 
> Available platforms: android, blackberry10, firefoxos, ios
> {quote}
> After this change:
> {quote}
> $ cordova platform
> Installed platforms: 
> Available platforms: amazon-fireos, android, blackberry10, firefoxos, ios
> {quote}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message