cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-6272) Fix subdir handling
Date Thu, 20 Mar 2014 23:01:51 GMT

    [ https://issues.apache.org/jira/browse/CB-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942473#comment-13942473
] 

ASF GitHub Bot commented on CB-6272:
------------------------------------

Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-plugman/pull/66#discussion_r10821163
  
    --- Diff: src/install.js ---
    @@ -399,6 +404,33 @@ function tryFetchDependency(dep, install) {
     
             } else if (fetchdata.source.type === 'git') {
                 return Q(fetchdata.source.url);
    +        } else if (fetchdata.source.type === 'dir') {
    +
    +            // Note: With fetch() independant from install()
    +            // $md5 = md5(uri)
    +            // Need a Hash(uri) --> $tmpDir/cordova-fetch/git-hostname.com-$md5/
    +            // plugin[id].install.source --> searchpath that matches fetch uri 	
    +
    +            // mapping to a directory of OS containing fetched plugins  
    --- End diff --
    
    This introduces trailing whitespace. Please don't.


> Fix subdir handling
> -------------------
>
>                 Key: CB-6272
>                 URL: https://issues.apache.org/jira/browse/CB-6272
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugman
>    Affects Versions: 3.5.0
>            Reporter: Josh Soref
>            Assignee: Jonathan Bond
>            Priority: Blocker
>
> CB-6160 landed [~jbondc]'s ae2ce7ac6325d1c6558365b4be82e5a8ff0983b9
> which broke some portion of install:
> +                if (dep.subdir) {
> +                    dep.subdir = path.join(dep.subdir.split('/'));
> ...
> -                    if (dep_subdir) {
> -                        dep_subdir = path.join.apply(null, dep_subdir.split('/'));



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message