cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse MacFadyen (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CB-5984) WP8 add/remove dll resources is crufty
Date Thu, 06 Mar 2014 01:09:43 GMT

     [ https://issues.apache.org/jira/browse/CB-5984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jesse MacFadyen resolved CB-5984.
---------------------------------

    Resolution: Fixed

Committed here: 5d09da295f20055d43fcf7df5848f8ae11d8d4bc

> WP8 add/remove dll resources is crufty
> --------------------------------------
>
>                 Key: CB-5984
>                 URL: https://issues.apache.org/jira/browse/CB-5984
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugman, WP8
>    Affects Versions: 3.4.0
>         Environment: Windows
>            Reporter: Jesse MacFadyen
>            Assignee: Jesse MacFadyen
>             Fix For: 3.5.0
>
>
> plugman + wp8 has support for adding/removing dll resources to the project, although
there are multiple potential issues with string comparison in filesnames.
> Code like this:
> {code:javascript}
> var parts = relative_path.split('\\');
> var dll_name = parts[parts.length - 1].substr(0, parts[parts.length - 1].length - 4);
> {code}
> Can easily be replaced with this :
> {code:javascript}
> var dll_name = path.basename(relative_path, '.dll');
> {code}
> I fear there are also latent bugs here, so more tests should also be added.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message