cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Gonzalez (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CB-5105) remove dead code for device.version from native plugin source
Date Mon, 03 Mar 2014 18:32:22 GMT

    [ https://issues.apache.org/jira/browse/CB-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918375#comment-13918375
] 

Martin Gonzalez edited comment on CB-5105 at 3/3/14 6:32 PM:
-------------------------------------------------------------

Created pull request about this issue:
https://github.com/apache/cordova-plugin-device/pull/13

Waiting for review and merge.


was (Author: martin.c.glez.glez):
Created pull request about this issue:
https://github.com/apache/cordova-plugin-device/pull/13

Waiting for merge.

> remove dead code for device.version from native plugin source
> -------------------------------------------------------------
>
>                 Key: CB-5105
>                 URL: https://issues.apache.org/jira/browse/CB-5105
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin Device
>    Affects Versions: 3.1.0
>            Reporter: Marcel Kinard
>            Assignee: Martin Gonzalez
>            Priority: Minor
>
> The solution for CB-5085 (and related) is for device.js to set device.cordova using CORDOVA_JS_BUILD_LABEL
from cordova.js, instead of having native code do that (usually with hardcoded values) and
return it back from exec(). So once CB-5085 is fixed in this way, then any native code that
computes device.version is dead. That dead code should be removed from cordova-plugin-device,
if for no other reason than reducing confusion.
> The following platforms are affected: Android, BB10, WP8, Win8.
> iOS is doing something special, but doing it right, so don't make any changes to iOS.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message