cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-4966) dialog
Date Wed, 26 Mar 2014 13:33:19 GMT

    [ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947906#comment-13947906
] 

ASF GitHub Bot commented on CB-4966:
------------------------------------

GitHub user zalun opened a pull request:

    https://github.com/apache/cordova-plugin-dialogs/pull/17

    CB-4966 Removing FirefoxOS Quirks

    * no need to add special permission (it's different API with the same name)
    * notification.css is added automatically
    
    This still creates dialogs inside main DOM

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zalun/cordova-plugin-dialogs add-css-to-DOM

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-dialogs/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17
    
----
commit 8016d774cbe19709c2d68024d2a74e85b7f6d372
Author: Piotr Zalewa <zalun@ubuntu.(none)>
Date:   2014-03-26T13:20:19Z

    Removing FirefoxOS Quirks
    * no need to add special permission (it's different API with the same name)
    * notification.css is added automatically

----


> dialog
> ------
>
>                 Key: CB-4966
>                 URL: https://issues.apache.org/jira/browse/CB-4966
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Plugin Dialogs
>         Environment: firefoxos
>            Reporter: Piotr Zalewa
>
> I started developing it - only the CSS is left - no idea how to conect it to main CSS
(is it needed?)
> https://github.com/zalun/cordova-plugin-dialogs



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message