cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Billau (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-4096) Android - Unify Whitelist Implemenations
Date Thu, 20 Mar 2014 15:27:00 GMT

    [ https://issues.apache.org/jira/browse/CB-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941840#comment-13941840
] 

Mike Billau commented on CB-4096:
---------------------------------

[~iclelland], yes that was the thread I was reading but somehow missed Andrew's argument against
using subdomains attribute. Fail. 
I didn't realize that the attribute was never documented, I assumed that since it was in the
instructions for setting up mobile-spec that it'd be in the Whitelist guide, but the only
mention of it in the official docs seems to be under the Blackberry section. In light of this
I agree, we should axe the subdomains=true attribute. Since it hasn't been documented, I think
it's fine to completely take it out instead of belatedly deprecating. I'll withdrawal my pull
request -- thanks a lot for the comments anyway.

> Android - Unify Whitelist Implemenations
> ----------------------------------------
>
>                 Key: CB-4096
>                 URL: https://issues.apache.org/jira/browse/CB-4096
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Android
>    Affects Versions: 3.0.0
>            Reporter: Andrew Grieve
>            Assignee: Ian Clelland
>             Fix For: 3.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message