cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-3208) contacts
Date Mon, 10 Mar 2014 18:25:50 GMT

    [ https://issues.apache.org/jira/browse/CB-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13926000#comment-13926000
] 

ASF GitHub Bot commented on CB-3208:
------------------------------------

Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-mobile-spec/pull/44#discussion_r10442686
  
    --- Diff: contacts/index.html ---
    @@ -127,8 +39,8 @@
             <span id="contacts_results"> </span>
         </div>
         <h2>Action</h2>
    -    <div class="btn large" onclick="getContacts();">Get phone's contacts</div>
    --- End diff --
    
    I'm -1 on mixing commits.
    
    You have code refactors (such as here) and bug fixes elsewhere, and platform portability
elsewhere.
    Please split each of these into distinct commits.
    
    It's very very very hard to review a change when it's doing lots of unrelated things together.


> contacts
> --------
>
>                 Key: CB-3208
>                 URL: https://issues.apache.org/jira/browse/CB-3208
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: FirefoxOS
>    Affects Versions: 2.6.0
>            Reporter: Herm Wong
>            Assignee: Herm Wong
>             Fix For: 3.4.0
>
>
> Contacts API spec: https://wiki.mozilla.org/WebAPI/ContactsAPI



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message