cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-3208) contacts
Date Mon, 10 Mar 2014 18:22:00 GMT

    [ https://issues.apache.org/jira/browse/CB-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925996#comment-13925996
] 

ASF GitHub Bot commented on CB-3208:
------------------------------------

Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-mobile-spec/pull/44#discussion_r10442560
  
    --- Diff: autotest/tests/contacts.tests.js ---
    @@ -341,13 +348,18 @@ describe("Contacts (navigator.contacts)", function () {
                         }
                         expect(obj.name.familyName).toBe('Delete');
                         expect(obj.name.givenName).toBe('Test');
    +                    if (cordova.platformId !== 'firefoxos') {
    +                        expect(obj.name.formatted).toBe('abcde');
    +                    }
    --- End diff --
    
    Why aren't you using } else { here ?


> contacts
> --------
>
>                 Key: CB-3208
>                 URL: https://issues.apache.org/jira/browse/CB-3208
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: FirefoxOS
>    Affects Versions: 2.6.0
>            Reporter: Herm Wong
>            Assignee: Herm Wong
>             Fix For: 3.4.0
>
>
> Contacts API spec: https://wiki.mozilla.org/WebAPI/ContactsAPI



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message