cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Soref (JIRA)" <>
Subject [jira] [Created] (CB-5990) findPlugins function doesn't honor its comment
Date Fri, 07 Feb 2014 19:48:24 GMT
Josh Soref created CB-5990:

             Summary: findPlugins function doesn't honor its comment
                 Key: CB-5990
             Project: Apache Cordova
          Issue Type: Bug
          Components: Plugman
    Affects Versions: 3.3.0
            Reporter: Josh Soref

This is the code:

    // List the directories in the path, ignoring any files, .svn, etc.
    findPlugins:function(plugins_dir) {
        var plugins = [],

        if (fs.existsSync(plugins_dir)) {
            plugins = fs.readdirSync(plugins_dir).filter(function (fileName) {
               stats = fs.statSync(path.join(plugins_dir, fileName));
               return fileName != '.svn' && fileName != 'CVS' && stats.isDirectory();

It will return .hg, .git, .bzr, ...

There's no reason to only special case .svn and CVS, but to not mention CVS in the comment.

This message was sent by Atlassian JIRA

View raw message