cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Kemp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-4662) Bad code in file autotest?
Date Tue, 11 Feb 2014 21:47:21 GMT

    [ https://issues.apache.org/jira/browse/CB-4662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898362#comment-13898362
] 

David Kemp commented on CB-4662:
--------------------------------

This code has been fixed < d662dd36a6e6109e13e3571b5488815b7307b6cb > in the current
release.
No effort has been made to patch previous versions.

> Bad code in file autotest?
> --------------------------
>
>                 Key: CB-4662
>                 URL: https://issues.apache.org/jira/browse/CB-4662
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: mobile-spec
>    Affects Versions: 2.9.0
>            Reporter: Peter
>            Assignee: David Kemp
>            Priority: Minor
>
> By inspection, this code in the File autotests seems incorrect
> {code}
>         function arrayBufferEqualsString(buf, str) {
>             var buf = new Uint8Array(ab);
>             var match = buf.length == str.length;
>             for (var i = 0; match && i < buf.length; i++) {
>                 match = buf[i] == str.charCodeAt(i);
>             }
>             return match;
>         }
> {code}
> Where does that _ab_ come from?
> Ref: https://github.com/apache/cordova-mobile-spec/blob/master/autotest/tests/file.tests.js



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message