cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Grieve (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CB-5725) A certain plugin's source code is malformed during prepare
Date Fri, 03 Jan 2014 19:17:53 GMT

     [ https://issues.apache.org/jira/browse/CB-5725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Grieve resolved CB-5725.
-------------------------------

    Resolution: Invalid
      Assignee: Andrew Grieve

Looks like the plugin is just broken. They've checked in the "cordova.define" line: https://github.com/jkirkell/ProgressHud-Plugman/blob/master/ProgressHud.js

> A certain plugin's source code is malformed during prepare
> ----------------------------------------------------------
>
>                 Key: CB-5725
>                 URL: https://issues.apache.org/jira/browse/CB-5725
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 3.3.0
>         Environment: Gentoo Linux 3.7.10-gentoo x86_x64
> Mac OS X Mavericks x64
>            Reporter: Peter Metz
>            Assignee: Andrew Grieve
>            Priority: Minor
>
> There is a certain plugin which if I install, the client code gets malformed after a
prepare invocation from the CLI.
> I couldn't reproduce it with other plugins, but with this one it is consistently broken
on OS X and Linux too.
> The issue in detail: The first and last line of the source code gets duplicated.
> The plugin can be found here: https://github.com/jkirkell/ProgressHud-Plugman
> Exact steps to reproduce it:
> $ cordova create a
> Creating a new cordova project with name "HelloCordova" and id "io.cordova.hellocordova"
at location …
> $ cd a
> $ cordova platform add ios
> Creating ios project...
> Preparing ios project
> $ cordova plugin add https://github.com/jkirkell/ProgressHud-Plugman
> Fetching plugin from "https://github.com/jkirkell/ProgressHud-Plugman"...
> Starting installation of "com.phonegap.plugins.progresshud" for ios
> Preparing ios project
> com.phonegap.plugins.progresshud installed on ios.
> $ cordova prepare
> Generating config.xml from defaults for platform "ios"
> Preparing ios project
> $ head -10 platforms/ios/www/plugins/com.phonegap.plugins.progresshud/ProgressHud.js

> cordova.define("com.phonegap.plugins.progresshud.ProgressHud", function(require, exports,
module) {cordova.define("com.phonegap.plugins.progresshud.ProgressHud", function(require,
exports, module) {//
> //  ProgressHud.js
> //
> // Originally created by Olivier Louvignes on 04/25/2012.
> // Updated by Jeff Kirkell on 09/16/2013
> //
> // Copyright 2013 Jeff Kirkell. All rights reserved.
> // MIT Licensed
> var exec = function (methodName, serviceName, options, success, error) {
> $ 
> I did the exact repro steps on OS X. On Linux I actually added android as a platform
to see if that makes any difference, it didn't.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message