cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse MacFadyen (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CB-5224) Fix invalid pattern for testing msbuild availability for wp7 - localization!
Date Fri, 10 Jan 2014 22:30:55 GMT

     [ https://issues.apache.org/jira/browse/CB-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jesse MacFadyen resolved CB-5224.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 3.4.0

Fixed with CB-5359 commit

> Fix invalid pattern for testing msbuild availability for wp7 - localization!
> ----------------------------------------------------------------------------
>
>                 Key: CB-5224
>                 URL: https://issues.apache.org/jira/browse/CB-5224
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: CordovaJS, WP8
>    Affects Versions: 3.1.0
>         Environment: Windows
>            Reporter: Natalia Bartol
>            Assignee: Jesse MacFadyen
>            Priority: Critical
>             Fix For: 3.4.0
>
>
> Please take a look at: 
> https://github.com/apache/cordova-wp8/pull/12
> "It looks like the regex used to check if msbuild is in the path is a bit flawed. For
example in the italian localization of msbuild the -version command outputs:
> Microsoft (R) Build Engine versione 4.0.30319.17929
> [Microsoft .NET Framework versione 4.0.30319.18051]
> Copyright (C) Microsoft Corporation. Tutti i diritti riservati.
> 4.0.30319.17929
> Locally I have circumvented the error by editing check_reqs.js however it would be better
to use a regex that takes into account localized versions of the .net framework"
> Patch is ready - very small change, thus critical priority.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message