cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shazron Abdullah (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CB-5026) Move setting of UIWebView properties into its own plugin from the core
Date Fri, 17 Jan 2014 01:03:19 GMT

     [ https://issues.apache.org/jira/browse/CB-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Shazron Abdullah updated CB-5026:
---------------------------------

    Description: 
See: https://github.com/apache/cordova-ios/blob/c66fc82bd0a49b940e0a5beb1563ecdb48cc7120/CordovaLib/Classes/CDVViewController.m#L245-L400

(except for the CDVLocalStorage stuff)

This 150 line behemoth should be in its own plugin (with onload="true"). Not sure about removing
it from core, but putting it in its own plugin in core is a start. 

Pros:
- if iOS >= 8 adds more properties, and people want to stick to Cordova 3.A and we only
support it in 3.B or 4.x, they only have to update a plugin and not the whole core.

Cons:
- if they rely on these settings, they will lose them when they upgrade if they don't install
a plugin, this won't be any different when they moved from 2.x to 3.x
- Yet Another Repo?


NOTE:
Do not forget to add docs, and upgrading docs.

  was:
See: https://github.com/apache/cordova-ios/blob/c66fc82bd0a49b940e0a5beb1563ecdb48cc7120/CordovaLib/Classes/CDVViewController.m#L245-L400

(except for the CDVLocalStorage stuff)

This 150 line behemoth should be in its own plugin (with onload="true"). Not sure about removing
it from core, but putting it in its own plugin in core is a start. 

Pros:
- if iOS >= 8 adds more properties, and people want to stick to Cordova 3.A and we only
support it in 3.B or 4.x, they only have to update a plugin and not the whole core.

Cons:
- if they rely on these settings, they will lose them when they upgrade if they don't install
a plugin, this won't be any different when they moved from 2.x to 3.x
- Yet Another Repo?


> Move setting of UIWebView properties into its own plugin from the core
> ----------------------------------------------------------------------
>
>                 Key: CB-5026
>                 URL: https://issues.apache.org/jira/browse/CB-5026
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: iOS
>    Affects Versions: Master
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>            Priority: Minor
>             Fix For: 3.4.0
>
>
> See: https://github.com/apache/cordova-ios/blob/c66fc82bd0a49b940e0a5beb1563ecdb48cc7120/CordovaLib/Classes/CDVViewController.m#L245-L400
> (except for the CDVLocalStorage stuff)
> This 150 line behemoth should be in its own plugin (with onload="true"). Not sure about
removing it from core, but putting it in its own plugin in core is a start. 
> Pros:
> - if iOS >= 8 adds more properties, and people want to stick to Cordova 3.A and we
only support it in 3.B or 4.x, they only have to update a plugin and not the whole core.
> Cons:
> - if they rely on these settings, they will lose them when they upgrade if they don't
install a plugin, this won't be any different when they moved from 2.x to 3.x
> - Yet Another Repo?
> NOTE:
> Do not forget to add docs, and upgrading docs.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message