cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bas Bosman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-4906) FB - Capture.java - method does not clean up stream
Date Sun, 26 Jan 2014 22:37:40 GMT

    [ https://issues.apache.org/jira/browse/CB-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882461#comment-13882461
] 

Bas Bosman commented on CB-4906:
--------------------------------

Pull request: https://github.com/apache/cordova-plugin-media-capture/pull/12

> FB - Capture.java - method does not clean up stream
> ---------------------------------------------------
>
>                 Key: CB-4906
>                 URL: https://issues.apache.org/jira/browse/CB-4906
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 2.9.0
>            Reporter: Peter
>            Priority: Minor
>
> Resolve FindBugs reported issue in *Capture.java*:
> Before
> {code}
> FileInputStream fis = new FileInputStream(DirectoryManager.getTempDirectoryPath(this.cordova.getActivity())
+ "/Capture.jpg");                    
> OutputStream os = this.cordova.getActivity().getContentResolver().openOutputStream(uri);
> byte[] buffer = new byte[4096];
> int len;
> while ((len = fis.read(buffer)) != -1) {
>     os.write(buffer, 0, len);
> }
> os.flush();
> os.close();
> fis.close();
> {code}
> After
> {code}
> FileInputStream fis = new FileInputStream(DirectoryManager.getTempDirectoryPath(this.cordova.getActivity())
+ "/Capture.jpg");
> try {
>     OutputStream os = this.cordova.getActivity().getContentResolver().openOutputStream(uri);
>     try {
>         byte[] buffer = new byte[4096];
>         int len;
>         while ((len = fis.read(buffer)) != -1) {
>             os.write(buffer, 0, len);
>         }
>         os.flush();
>     } finally {
>         os.close();
>     }
> } finally {
>     fis.close();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message