cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Gill (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-5605) plugman install.js:68 crashes
Date Thu, 12 Dec 2013 00:36:11 GMT

    [ https://issues.apache.org/jira/browse/CB-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845920#comment-13845920
] 

Steve Gill commented on CB-5605:
--------------------------------

So I have added a version script to cordova-firefoxos repo now. It will be coming out with
3.3 tomorrow. Can you test it to see if it is fixed by cloning https://git-wip-us.apache.org/repos/asf?p=cordova-firefoxos.git;a=summary.
You could also wait until 3.3.0 is released and let us know on this comment. 

> plugman install.js:68 crashes
> -----------------------------
>
>                 Key: CB-5605
>                 URL: https://issues.apache.org/jira/browse/CB-5605
>             Project: Apache Cordova
>          Issue Type: Bug
>            Reporter: Axel Nennker
>            Assignee: Steve Gill
>
> My app uses two custom plugins.
> I want to add firefoxos as a platform.
> When I issue a
> cordova platform add firefoxos
> install.js:68 fails with the message
> "Cannot access currentVersion of null"
> I guess my custom plugins' plugin.xml are wrong...
> Anyway I think that install.js should not crash here.
> I have no idea why engines[i] is null for some i.
> -Axel
> Maybe this code is a fix:
> function checkEngines(engines) {
>     for(var i = 0; i < engines.length; i++) {
>         var engine = engines[i];
>         if(engine===null) {
>           return Q.reject(new Error('Plugin doesn\'t support this project'));
>         } else {
>           if(semver.satisfies(engine.currentVersion, engine.minVersion) || engine.currentVersion
== null){
>             // engine ok!
>           }else{
>             return Q.reject(new Error('Plugin doesn\'t support this project\'s '+engine.name+'
version. '+engine.name+': ' + engine.currentVersion + ', failed version requirement: ' + engine.minVersion));
>           }
>         }
>     }
>     return Q(true);
> }
> Although I never see the no-support output



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message