cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Grieve (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CB-3762) notification.prompt doesn't accept an empty string for default text
Date Fri, 06 Dec 2013 19:59:37 GMT

     [ https://issues.apache.org/jira/browse/CB-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Grieve resolved CB-3762.
-------------------------------

    Resolution: Fixed

> notification.prompt doesn't accept an empty string for default text
> -------------------------------------------------------------------
>
>                 Key: CB-3762
>                 URL: https://issues.apache.org/jira/browse/CB-3762
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Dialogs
>    Affects Versions: 2.7.0, 2.8.0
>            Reporter: Todd Miller
>            Assignee: Mike Billau
>            Priority: Minor
>             Fix For: 3.3.0
>
>
> Specifying "" as the last parameter for navigator.notification.prompt, the prompt dialog
will still show "Default Text" in the text input box. However, putting a string of just a
single space works (but also results in a space in the text box).
> In additional seems like the default of "Default Text" isn't the best choice from UX
perspective. A default of an empty text box would make more sense.
> Changing line 5909 in cordova.js from:
> var _defaultText = (defaultText || "Default text");
> to
> var _defaultText = (defaultText || "");
> Resolves the issue and gives a blank text box by default. Documentation would also need
to be updated with the new default if this is adopted.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message