cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Williams (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-5093) CLI builds version number inconsitently between iOS and Android
Date Mon, 11 Nov 2013 15:46:18 GMT

    [ https://issues.apache.org/jira/browse/CB-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13819040#comment-13819040
] 

Tim Williams commented on CB-5093:
----------------------------------

I think the Android issue is because the android_parser.update_from_config function currently
doesn't set the versionCode in the generated AndroidManifest.xml. It needs a repeat of the
code used to set the versionName.

~ Line 100 here:
https://github.com/apache/cordova-cli/blob/master/src/metadata/android_parser.js?source=cc

> CLI builds version number inconsitently between iOS and Android
> ---------------------------------------------------------------
>
>                 Key: CB-5093
>                 URL: https://issues.apache.org/jira/browse/CB-5093
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android, CLI, iOS
>    Affects Versions: 3.1.0
>            Reporter: Adam George
>            Assignee: Joe Bowser
>
> I'm hoping this issue isn't just my ignorance, but I'm finding the app version number
generation via the CLI to be inconsistent and odd.
> iOS and Android both support a version number (which is what is displayed in the app
stores), as well as another string, which most people use as a build number.
> E.g. for iOS:
> Myapp-Info.plist:
> Bundle versions string, short:   1.0.0     (this is what will show in the app store)
> Bundle version:  0.0.3    (this is some other build number)
> Android:
> AndroidManifest.xml:
> android:versionCode="1" android:versionName="0.0.3"
> versionName is what shows in the stores, and versionCode is typically used like a build
number (as far as I can tell).
> My point is, in the cordova.xml, I only have the ability to set one of these version
numbers.  There is only a single "version" attribute.
> But we need two attributes, so we can set both version strings via the CLI.
> Secondly, how the "version" attribute is applied when building via the CLI is inconsistent.
 On iOS it's updating the "build" number, and not even touching the main version number that
users will see in the store.
> Whereas Android has what I would expect as the correct behaviour.
> Anyway, please let me know if I've misunderstood anything.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message