cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Bond (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-4609) relative path to cordova.js & windows path
Date Mon, 04 Nov 2013 14:19:22 GMT

    [ https://issues.apache.org/jira/browse/CB-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812861#comment-13812861
] 

Jonathan Bond commented on CB-4609:
-----------------------------------

Any thoughts on Issue #1?
Should I re-submit a patch for it? 

I'm still on 2.x but hoping to upgrade.


> relative path to cordova.js & windows path
> ------------------------------------------
>
>                 Key: CB-4609
>                 URL: https://issues.apache.org/jira/browse/CB-4609
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI, Plugman
>    Affects Versions: 3.0.0
>         Environment: Window 8, node v0.10.16
>            Reporter: Jonathan Bond
>            Assignee: Filip Maj
>         Attachments: Result of 'plugin add'.jpg
>
>
> I'm experimenting with a new plugin:
> https://github.com/jbondc/cordova-plugin-gesture
> To reproduce:
> - Download https://github.com/jbondc/mtlhack-PhoneGap-gesture
> 1) Issue #1
> {code}
> cd cordova
> plugin add https://github.com/jbondc/cordova-plugin-gesture
> {code}
> Since cordova.js isn't in the default path (www/resources/cordova.js), the plugins gets
copied to (www/plugins/) instead of (www/resources/js/plugins).
> The same for 'cordova_plugins.js' (see attached screenshot)
> Fix is likely in the cli/plugman to set find the appropriate root/base path to cordova.js
> 2) Issue #2
> Adding a plugin from a Windows path
> {code}
> cordova plugin add F:\Jonathan\GitHub\Cordova\cordova-plugin-gesture
> {code}
> In cordova_plugins.js, I see:
> {code}
> cordova.define('cordova/plugin_list', function(require, exports, module) {
> module.exports = [
>     {
>         "file": "plugins\\org.apache.cordova.core.Gesture\\www\\gesture.js",
>         "id": "org.apache.cordova.core.Gesture.Gesture",
>         "clobbers": [
>             "cordova.gesture"
>         ]
>     }
> ]
> });
> {code}
> That path should be normalized to: "plugins/org.apache.cordova.core.Gesture/www/gesture.js"
> Fix is likely in cli/plugman:
> {code}path.replace("\\", "/"){code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message