Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Date: Thu, 3 Oct 2013 22:20:47 +0000 (UTC)
From: "Hyong Kim (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12672231.1380838825279.9539.1380838847174@arcas>
In-Reply-To: <JIRA.12672231.1380838825279@arcas>
References: <JIRA.12672231.1380838825279@arcas>
Subject: [jira] [Created] (CB-4995) iOS application crashes when
 InAppBrowser is opened and quickly closed
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Hyong Kim created CB-4995:
-----------------------------

             Summary: iOS application crashes when InAppBrowser is opened and quickly closed
                 Key: CB-4995
                 URL: https://issues.apache.org/jira/browse/CB-4995
             Project: Apache Cordova
          Issue Type: Bug
          Components: Plugin InAppBrowser
    Affects Versions: 3.0.0, 2.9.0, 2.8.0, 2.7.0
         Environment: iOS
            Reporter: Hyong Kim


I personally experienced the issue with 2.8.15, but it appears others are seeing the same problem even on version 3. Just now, I quickly took a look at the latest version 3 source code, and it is likely that the issue is still around. That is, I had identified the cause of the crash and we fixed it in our app.

The issue is presented when a user rapidly opens and closes InAppBrowser while using Cordova iOS application because (referring to the latest CDVInAppBrowser.m as of 10/3/2013 with commit hash of a001cffc30cf94cb406128f7b68d143e2cd62114) self.inAppBrowserViewController (line: 332) is nil if 'browserExit' (line: 353) is called before 'webViewDidFinishLoad' (line: 328) is invoked.

We put our own patch around line 332 as below, and didn't experience the crash any more with 2.8.15

if (self.inAppBrowserViewController != nil) {
    url = [self.inAppBrowserViewController.currentURL absoluteString];  
} else {
    url = @"";
}


--
This message was sent by Atlassian JIRA
(v6.1#6144)