cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Grebnov (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CB-5183) WP7/8 custom_path is not correctly resolved by CLI
Date Wed, 23 Oct 2013 07:51:41 GMT

    [ https://issues.apache.org/jira/browse/CB-5183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802680#comment-13802680
] 

Sergey Grebnov edited comment on CB-5183 at 10/23/13 7:50 AM:
--------------------------------------------------------------

This is because wp8_parser.js tries to interpreter uri parameter (custom_path) as location
to cordova-wp8/wp8, not to root cordova-wp8 folder.
https://github.com/apache/cordova-cli/blob/master/src/metadata/wp8_parser.js#L52

module.exports.check_requirements = function(project_root) {
..
    var lib_path = path.join(util.libDirectory, 'wp', 'cordova', require('../../platforms').wp8.version,
'wp8');
    var custom_path = config.has_custom_path(project_root, 'wp8');
    if (custom_path) lib_path = custom_path;

Actually lib_path in case of custom path must be
if (custom_path) lib_path = path.join(custom_path, 'wp8')

PS. Specifying cordova-wp8/wp8 sub folder in config.json to fix this problem is incorrect
since
a) wp8 sub folder does not contain all necessary content for wp8; the correct root folder
to specify is cordova-wp8
b) update_www function will fail in this case since it use custom_path as a root for common/www
folder which is located in cordova-wp8 (not cordova-wp8/wp8)

Same with wp7



was (Author: sgrebnov):
This is because wp8_parser.json tries to interpreter uri parameter (custom_path) as location
to cordova-wp8/wp8, not to root cordova-wp8 folder.
https://github.com/apache/cordova-cli/blob/master/src/metadata/wp8_parser.js#L52

module.exports.check_requirements = function(project_root) {
..
    var lib_path = path.join(util.libDirectory, 'wp', 'cordova', require('../../platforms').wp8.version,
'wp8');
    var custom_path = config.has_custom_path(project_root, 'wp8');
    if (custom_path) lib_path = custom_path;

Actually lib_path in case of custom path must be
if (custom_path) lib_path = path.join(custom_path, 'wp8')

PS. Specifying cordova-wp8/wp8 sub folder in config.json to fix this problem is incorrect
since
a) wp8 sub folder does not contain all necessary content for wp8; the correct root folder
to specify is cordova-wp8
b) update_www function will fail in this case since it use custom_path as a root for common/www
folder which is located in cordova-wp8 (not cordova-wp8/wp8)

Same with wp7


> WP7/8 custom_path is not correctly resolved by CLI
> --------------------------------------------------
>
>                 Key: CB-5183
>                 URL: https://issues.apache.org/jira/browse/CB-5183
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>            Reporter: Sergey Grebnov
>            Assignee: Sergey Grebnov
>            Priority: Minor
>
> Steps to reproduce
> 1. Install latest cordova-cli from git repo
> 2. Create new project App using 'cordova create App' CLI command 
> 3. Update app/.cordova/config.json to point to custom cordova-wp8 repo
>  For example
> {  "id":"org.apache.mobilespec",  "name":"mobilespec",  "lib": { "wp8": {      "uri":
"c:\\..\\cordova-wp8",      "version": "3.1.0",      "id": "cordova-wp8-master"    }  }}
> 4. Run 'cordova platform add wp8' commands
> Expected: command succeeded.
> Actually: command failed with the message below
> Error: Error while checking requirements: '"c:\..\cordova-wp8\bin\check_reqs"' is not
recognized as an internal or external command,
> operable program or batch file.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message