cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shazron Abdullah (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-4806) Update splashscreen image bounds for iOS 7
Date Mon, 07 Oct 2013 19:41:43 GMT

    [ https://issues.apache.org/jira/browse/CB-4806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788490#comment-13788490
] 

Shazron Abdullah commented on CB-4806:
--------------------------------------

Based on the last plugin version, I anticipate this fix will be in the splashscreen plugin
v0.2.3

> Update splashscreen image bounds for iOS 7
> ------------------------------------------
>
>                 Key: CB-4806
>                 URL: https://issues.apache.org/jira/browse/CB-4806
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: iOS, Plugin SplashScreen
>    Affects Versions: Master
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>              Labels: ios7
>             Fix For: 3.1.0
>
>
> See code from this thread: http://markmail.org/message/khqi5vpubxp2qppk
> diff replicated below:
> {code}
> diff --git a/CordovaLib/Classes/CDVSplashScreen.m
> b/CordovaLib/Classes/CDVSplashScreen.m
> index fdb79fa..809ce35 100644
> --- a/CordovaLib/Classes/CDVSplashScreen.m
> +++ b/CordovaLib/Classes/CDVSplashScreen.m
> @@ -170,7 +170,9 @@
>      // There's a special case when the image is the size of the screen.
>      if (CGSizeEqualToSize(screenSize, imgBounds.size)) {
>          CGRect statusFrame = [self.viewController.view
> convertRect:[UIApplication sharedApplication].statusBarFrame fromView:nil];
> -        imgBounds.origin.y -= statusFrame.size.height;
> +        if (floor(NSFoundationVersionNumber) <=
> NSFoundationVersionNumber_iOS_6_1) {
> +            imgBounds.origin.y -= statusFrame.size.height;
> +        }
>      } else {
>          CGRect viewBounds = self.viewController.view.bounds;
>          CGFloat imgAspect = imgBounds.size.width / imgBounds.size.height;
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message