Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Date: Tue, 3 Sep 2013 17:45:52 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12663797.1376541136819.72343.1378230352448@arcas>
In-Reply-To: <JIRA.12663797.1376541136819@arcas>
References: <JIRA.12663797.1376541136819@arcas>
Subject: [jira] [Commented] (CB-4588) Documentation for notification.confirm
 should say to pass buttonLabels as Array
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756822#comment-13756822 ] 

ASF subversion and git services commented on CB-4588:
-----------------------------------------------------

Commit 15ee26ddf96337a2908cc48f6537da122c3dadce in branch refs/heads/master from [~lorin]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=15ee26d ]

[CB-4588] updated button labels example code to use array syntax, from deprecated comma separated string syntax

                
> Documentation for notification.confirm should say to pass buttonLabels as Array
> -------------------------------------------------------------------------------
>
>                 Key: CB-4588
>                 URL: https://issues.apache.org/jira/browse/CB-4588
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Docs
>    Affects Versions: 2.9.0
>            Reporter: Peter
>            Assignee: Lorin Beer
>            Priority: Minor
>
> Compare navigator.notification.confirm and navigator.notification.prompt.
> Both APIs allow caller to specifiy *buttonLabels* as 4th parameter, but confirm expects a comma separated String and prompt expects an array. The parameter passing mechanism should be consistent for these similar APIs.
> It looks like the cordova.js is already handling the scenario, because it says:
> {code}
> console.log("Notification.confirm(string, function, string, string) is deprecated.  Use Notification.confirm(string, function, string, array).");
> {code}
> But the documentation for navigator.confirm is out-of-step with the code; it should be updated to say to pass Array, not String.
> Seems related to CB-1933

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira