cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Billau (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-4811) Device plugin requires no permissions, so remove from documentaion
Date Fri, 13 Sep 2013 17:26:51 GMT

    [ https://issues.apache.org/jira/browse/CB-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766680#comment-13766680
] 

Mike Billau commented on CB-4811:
---------------------------------

Pull request: https://github.com/apache/cordova-docs/pull/113  (assuming I'm not crazy!)
                
> Device plugin requires no permissions, so remove from documentaion 
> -------------------------------------------------------------------
>
>                 Key: CB-4811
>                 URL: https://issues.apache.org/jira/browse/CB-4811
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Docs, Plugin Device
>    Affects Versions: 3.0.0
>         Environment: Windows 7
>            Reporter: Mike Billau
>            Assignee: Michael Brooks
>            Priority: Minor
>
> The docs for the cordova-plugin-device plugin (http://cordova.apache.org/docs/en/edge/cordova_device_device.md.html#Device)
say that the plugin will add 
> <uses-permission android:name="android.permission.READ_PHONE_STATE" />
> to AndroidManifest.xml
> However, it seems like this is not actually the case, because 1) there is nothing in
the plugin.xml file that would do this (missing <config-file target="AndroidManifest.xml"
parent="/*">[...]) element, and 2) it doesn't seem like the device functionality needs
this permission at all. 
> Unless there are some strange dependencies that I'm not seeing between other plugins
that require the device plugin to have this permission (that wouldn't make sense...?), I think
the docs should be edited to reflect this to avoid causing confusion (it confused me at least!)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message