Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D3EA01061E for ; Mon, 26 Aug 2013 02:00:52 +0000 (UTC) Received: (qmail 57396 invoked by uid 500); 26 Aug 2013 02:00:52 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 57376 invoked by uid 500); 26 Aug 2013 02:00:52 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 57367 invoked by uid 99); 26 Aug 2013 02:00:52 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Aug 2013 02:00:52 +0000 Date: Mon, 26 Aug 2013 02:00:52 +0000 (UTC) From: "Jonathan Bond-Caron (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-4609) relative path to cordova.js & windows path MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749787#comment-13749787 ] Jonathan Bond-Caron commented on CB-4609: ----------------------------------------- Here are the 3 pull requests: https://github.com/apache/cordova-plugman/pull/20 https://github.com/apache/cordova-cli/pull/32 https://github.com/apache/cordova-android/pull/78 For 'Android', I'm not sure why cordova/version.bat is different than cordova/version > relative path to cordova.js & windows path > ------------------------------------------ > > Key: CB-4609 > URL: https://issues.apache.org/jira/browse/CB-4609 > Project: Apache Cordova > Issue Type: Bug > Components: CLI, Plugman > Affects Versions: 3.0.0 > Environment: Window 8, node v0.10.16 > Reporter: Jonathan Bond-Caron > Assignee: Filip Maj > Attachments: Result of 'plugin add'.jpg > > > I'm experimenting with a new plugin: > https://github.com/jbondc/cordova-plugin-gesture > To reproduce: > - Download https://github.com/jbondc/mtlhack-PhoneGap-gesture > 1) Issue #1 > {code} > cd cordova > plugin add https://github.com/jbondc/cordova-plugin-gesture > {code} > Since cordova.js isn't in the default path (www/resources/cordova.js), the plugins gets copied to (www/plugins/) instead of (www/resources/js/plugins). > The same for 'cordova_plugins.js' (see attached screenshot) > Fix is likely in the cli/plugman to set find the appropriate root/base path to cordova.js > 2) Issue #2 > Adding a plugin from a Windows path > {code} > cordova plugin add F:\Jonathan\GitHub\Cordova\cordova-plugin-gesture > {code} > In cordova_plugins.js, I see: > {code} > cordova.define('cordova/plugin_list', function(require, exports, module) { > module.exports = [ > { > "file": "plugins\\org.apache.cordova.core.Gesture\\www\\gesture.js", > "id": "org.apache.cordova.core.Gesture.Gesture", > "clobbers": [ > "cordova.gesture" > ] > } > ] > }); > {code} > That path should be normalized to: "plugins/org.apache.cordova.core.Gesture/www/gesture.js" > Fix is likely in cli/plugman: > {code}path.replace("\\", "/"){code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira