cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Grieve (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (CB-4480) CDVFileTransfer - handling big files >2GB is not correct
Date Fri, 02 Aug 2013 17:55:52 GMT

     [ https://issues.apache.org/jira/browse/CB-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Grieve closed CB-4480.
-----------------------------

    Resolution: Fixed
      Assignee: Andrew Grieve  (was: Steve Gill)

Patched in your change, but just had to fix up using NSInteger in the connection delegate
(it's not our signature to change). And also used long long instead of unsigned since it will
be unsigned once it gets to JS anyways.
                
> CDVFileTransfer - handling big files >2GB is not correct
> --------------------------------------------------------
>
>                 Key: CB-4480
>                 URL: https://issues.apache.org/jira/browse/CB-4480
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File Transfer
>    Affects Versions: 2.9.0, 3.0.0
>         Environment: iOS in general
>            Reporter: Klaus Schmidt
>            Assignee: Andrew Grieve
>              Labels: patch
>         Attachments: CDVFileTransfer.h.diff, CDVFileTransfer.m.diff
>
>
> Hello Cordova Team,
> we needed to download big files (>2GB) via FileTransfer and use the onProgressEvent
to display the progress.
> On Android everything is fine. On iOS the reported sizes in the onProgressEvent are not
valid, if the downloaded file is larger than 2GB:
> {{CDVFileTransfer}} uses {{NSInteger}} for {{bytesTransfered}} and {{bytesExpected}}.
{{NSInteger}} only is up to 2G-1 as mentioned here: http://stackoverflow.com/questions/2107544/types-in-objective-c-on-iphone
> We patched the library files {{CDVFileTransfer.h}} and {{CDVFileTransfer.m}} of version
2.9.0 to use "unsigned long long" - now we are able to display downloads up to 16Exabytes-1byte
correctly. We can see in github, that version 3.0.0 has the same issue.
> I will add the diff in the issue after creating it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message