cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Kim (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-4036) <platform> tag should have a "version" attribute
Date Wed, 07 Aug 2013 22:18:47 GMT

    [ https://issues.apache.org/jira/browse/CB-4036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13732831#comment-13732831
] 

Tim Kim commented on CB-4036:
-----------------------------

Ok, I've made another pass at this with the commit in the comment above. It's not fully tested
and I'm not even sure if it works right now (have to change the tests), but I figured I'd
push it up just so I could show you all.

Anywho, I went with the idea that we do all of our version checks within the engine tag. I've
also added support such that there are defaults for the engines we know about (placed in util/default-engines)
as well the ability to add custom engines that need to be checked.


                
> <platform> tag should have a "version" attribute 
> -------------------------------------------------
>
>                 Key: CB-4036
>                 URL: https://issues.apache.org/jira/browse/CB-4036
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugman
>            Reporter: Shazron Abdullah
>            Assignee: Filip Maj
>
> This might be hole that we didn't consider.
> I know implicitly if the plugin supported an "engine" version we support what the engine
supports, but here could be one scenario.
> For example, with iOS 7, a plugin CDVFooBar use this awesome NSWhizBang framework. Fine,
with iOS 7, you have to of course build with the iOS 7 SDK, and you can support iOS 6 with
a Deploy Target build setting.
> It runs on iOS 7 - yay.
> It.. blows up on iOS 6 at runtime, because of course NSWhizBang framework does not exist
on iOS 6.
> Now you say, why don't you do Obj-C runtime checks and weak link the framework? Yes,
the plugin author can do that but a plugin user, by parsing the plugin xml (using a tool,
or optically, whatever) cannot know that the plugin does NOT work on iOS 6 - and even though
it "runs" on iOS 6, it does nothing, which is useless and wastes a lot of time.
> So - my proposal is, to add a *"version"* attribute on the *<platform>* tag. It
should follow the syntax for the <engine> version attribute. 
> What would be the default if the version attribute is not there? Not sure what a reasonable
default is yet.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message