Return-Path: 
 <issues-return-10330-apmail-cordova-issues-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org
Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 7B8D810D03
	for <apmail-cordova-issues-archive@minotaur.apache.org>;
 Thu, 25 Jul 2013 00:05:49 +0000 (UTC)
Received: (qmail 80681 invoked by uid 500); 25 Jul 2013 00:05:49 -0000
Delivered-To: apmail-cordova-issues-archive@cordova.apache.org
Received: (qmail 80630 invoked by uid 500); 25 Jul 2013 00:05:49 -0000
Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cordova.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cordova.apache.org>
List-Post: <mailto:issues@cordova.apache.org>
List-Id: <issues.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list issues@cordova.apache.org
Received: (qmail 80620 invoked by uid 99); 25 Jul 2013 00:05:49 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Jul 2013 00:05:49 +0000
Date: Thu, 25 Jul 2013 00:05:49 +0000 (UTC)
From: "Maciej Jaros (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12659614.1374683688795.108142.1374710749327@arcas>
In-Reply-To: <JIRA.12659614.1374683688795@arcas>
References: <JIRA.12659614.1374683688795@arcas>
Subject: [jira] [Commented] (CB-4379) Android PluginManager not loading
 plugins from config.xml
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CB-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719063#comment-13719063 ] 

Maciej Jaros commented on CB-4379:
----------------------------------

I'm using crodova 3.0 with plugman. It's plugman that adds the tag... but I guess this is beacause it is mentioned in plugin.xml. Can't you just read old entries at least for now?

This is the currently added BarcodeScanner tag:
{code:xml}
    <plugin name="BarcodeScanner" value="com.phonegap.plugins.barcodescanner.BarcodeScanner" />
{code}

Is the below correct (expected) for the new, feature only syntax?
{code:xml}
    <feature name="BarcodeScanner">
        <param name="android-package" value="com.phonegap.plugins.barcodescanner.BarcodeScanner" />
    </feature>
{code}

What code should be added for iOS (assuming current code is as below)?
{code:xml}
    <plugin name="BarcodeScanner" value="CDVBarcodeScanner"/>
{code}

                
> Android PluginManager not loading plugins from config.xml
> ---------------------------------------------------------
>
>                 Key: CB-4379
>                 URL: https://issues.apache.org/jira/browse/CB-4379
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>         Environment: Windows 7 x64 (but should not be relevant)
>            Reporter: Maciej Jaros
>            Assignee: Joe Bowser
>
> When I try to use BarcodeScanner I keep getting "Class not found".
> After debugging with cordova from master I noticed loadPlugins function doesn't set service/class values for plugins.
> There seem to be a missing if (around line #130):
> {code:java}
>                 }
>                 else if (strNode.equals("plugin")) {
>                     service = xml.getAttributeValue(null, "name");
>                     pluginClass = xml.getAttributeValue(null, "value");
>                 }
>                 else if (insideFeature && strNode.equals("param")) {
> {code}
> Tested this on Android 4.2 (Nexus 7) and it seem to work fine. At the moment the mentioned plugin is not working but will add a patch for that today.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira