cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Filip Maj (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-4077) CLI / Plugman can't remove dependency-only plugins
Date Fri, 05 Jul 2013 17:05:48 GMT

    [ https://issues.apache.org/jira/browse/CB-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13701001#comment-13701001
] 

Filip Maj commented on CB-4077:
-------------------------------

The code looks good. A few notes, all test related:

 - when i run the tests ({{npm test}}) for plugman, I get three failures. We should probably
add new tests to cover the changes you introduced, as well as fix the old tests.
 - same things for cordova-cli.
                
> CLI / Plugman can't remove dependency-only plugins
> --------------------------------------------------
>
>                 Key: CB-4077
>                 URL: https://issues.apache.org/jira/browse/CB-4077
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI, Plugman
>    Affects Versions: 3.0.0
>            Reporter: Ian Clelland
>            Assignee: Filip Maj
>
> {{cordova plugin remove}} cannot delete dependency-only plugins, which do not have any
platforms defined in their {{plugin.xml}} file. {{plugman.uninstall()}} is only called for
platforms, not for the plugin itself.
> I propose fixing this by separating the tasks of
> * removing a plugin from a particular platform, and
> * removing a plugin from the cordova project
> Dependency-only projects need the second step to occur, but not the first.
> Other plugins will have the first step run once per platform, and then the second step
run once.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message