Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Date: Fri, 28 Jun 2013 13:29:21 +0000 (UTC)
From: "Ian Clelland (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12654789.1372188049573.183688.1372426161568@arcas>
In-Reply-To: <JIRA.12654789.1372188049573@arcas>
References: <JIRA.12654789.1372188049573@arcas>
Subject: [jira] [Commented] (CB-4004) FileWriter fails to write large binary
 files
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-4004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13695441#comment-13695441 ] 

Ian Clelland commented on CB-4004:
----------------------------------

I don't think we can accept this patch as-is -- the included Base64 implementation seems to be taken from here:
https://gist.github.com/jonleighton/958841 although I haven't tried to verify the original authorship. (If that's not the case, I apologise)

It's not the fastest algorithm we could be using anyway, though -- I ran a bunch of performance tests on different base64 implementations last night, and the best I could get gives about a 4.5x speed improvement over this, at the cost of an 8K static array.

Once the ICLA is confirmed, Chris, I'll definitely take in the structure of your patch, but without the base64 piece. 
                
> FileWriter fails to write large binary files
> --------------------------------------------
>
>                 Key: CB-4004
>                 URL: https://issues.apache.org/jira/browse/CB-4004
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>         Environment: Android (tested on Nexus 7, Android 4.2)
>            Reporter: Chris Barton
>            Assignee: Ian Clelland
>            Priority: Minor
>
> When attempting to write a file or blob (let's say a 5MB zip archive) to disk via FileWriter#write, I receive a "RangeError, Maximum call stack size exceeded" when trying to turn the ArrayBuffer into a Base64 string in #exec.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira