Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Date: Fri, 31 May 2013 22:30:20 +0000 (UTC)
From: "Shazron Abdullah (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12649843.1369805995032.49444.1370039420647@arcas>
In-Reply-To: <JIRA.12649843.1369805995032@arcas>
References: <JIRA.12649843.1369805995032@arcas>
Subject: [jira] [Commented] (CB-3530) PhoneGap app crashes on iOS with error
 "CDVWebViewDelegate: Navigation started when state=1"
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671864#comment-13671864 ] 

Shazron Abdullah commented on CB-3530:
--------------------------------------

Still couldn't repro, but found the culprit I think (thanks for the clues in the description): https://github.com/apache/cordova-ios/blob/7e0a32892a540295e7de5da6a4832dfdaf337ac0/CordovaLib/Classes/CDVWebViewDelegate.m#L200

didFailLoadWithError code always assumes that the NSError passed in is not nil. The fix is not to pass in nil there but create a default one.
                
> PhoneGap app crashes on iOS with error "CDVWebViewDelegate: Navigation started when state=1"
> --------------------------------------------------------------------------------------------
>
>                 Key: CB-3530
>                 URL: https://issues.apache.org/jira/browse/CB-3530
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS, Plugin InAppBrowser
>    Affects Versions: 2.7.0
>         Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1
>            Reporter: Montyleena
>            Assignee: Shazron Abdullah
>              Labels: crash, iOS,, inappbrowser,
>             Fix For: 2.8.0
>
>
> I have a PhoneGap app on iOS which was working fine with PhoneGap 2.3.0 but crashes with 2.7.0 with the following error:
> 2013-05-02 10:08:13.214 App[8896:c07] CDVWebViewDelegate: Navigation started when state=1
> 2013-05-02 10:08:13.215 App[8896:c07] Failed to load webpage with error: (null)
> The problem is:
> CDVWebViewDelegate.m: shouldStartLoadWithRequest() function: In switch case, default: error code is being passed as nil
> and in CDVInAppBrowser.m: didFailLoadWithError() function, error.localizedDescription is being referenced, which causes a crash as error object is nil. 
> For now, i added a check in the above function to put default values for error code if the error object is nil. I hope this crash is fixed in the next PhoneGap release.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira