Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1F6E8DE5E for ; Fri, 15 Mar 2013 19:20:15 +0000 (UTC) Received: (qmail 26754 invoked by uid 500); 15 Mar 2013 19:20:14 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 26723 invoked by uid 500); 15 Mar 2013 19:20:14 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 26646 invoked by uid 99); 15 Mar 2013 19:20:14 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Mar 2013 19:20:13 +0000 Date: Fri, 15 Mar 2013 19:20:13 +0000 (UTC) From: "Andrew Grieve (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-2661) InAppBrowser creates channels per-instance, and Channels are assumed to be unique-per-name MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603727#comment-13603727 ] Andrew Grieve commented on CB-2661: ----------------------------------- I was thinking that when the channels are created, they can use: {code} channel.onCordovaReady = channel.create('onCordovaReady') {code} > InAppBrowser creates channels per-instance, and Channels are assumed to be unique-per-name > ------------------------------------------------------------------------------------------ > > Key: CB-2661 > URL: https://issues.apache.org/jira/browse/CB-2661 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaJS > Reporter: Andrew Grieve > Assignee: Andrew Grieve > Priority: Minor > > The problem with this is that the channel module maintains a reference to each channel in create(): > channel[name] = channel; > We should just remove this behaviour from channel.js and figure out if anyone was depending on it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira